Add pre-commit hook for yaml formatting - #277
Merged
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces YAML formatting enforcement via pre-commit and applies consistent YAML formatting across existing configuration and GitHub workflow files.
Changes:
- Add a
yamlfmtpre-commit hook and reformat.pre-commit-config.yamlaccordingly. - Apply YAML formatting updates to
config/simapp.yamland various.github/*.ymlfiles (mostly whitespace/indentation normalization). - Remove stray blank lines in YAML configs (e.g.,
.golangci.yml, Dependabot, workflows) to match the formatter output.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
config/simapp.yaml |
YAML reformatting (indentation/sequence formatting) plus touched inline comments. |
.pre-commit-config.yaml |
Re-indented config and added google/yamlfmt hook. |
.golangci.yml |
YAML whitespace cleanup (blank line removal). |
.github/workflows/stale.yml |
YAML whitespace cleanup (blank line removal). |
.github/workflows/push.yml |
YAML whitespace cleanup (blank line removal). |
.github/workflows/main.yml |
YAML whitespace cleanup (blank line removal). |
.github/dependabot.yml |
YAML whitespace cleanup (blank line removal). |
Suppressed comments (1)
config/simapp.yaml:135
- Spelling/grammar in the inline comment: use "don't" instead of "dont".
rule-trigger: "timer,10" #dont create this bearer immediately. Create after 10 sec time.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| upf: | ||
| upf-name: upf.menlo.aetherproject.org | ||
| upf-port: 8805 | ||
| rule-trigger: api #dont create this bearer immediately. Wait for API call |
| arp: 6 | ||
| pdb: 300 | ||
| pelr: 6 | ||
| rule-trigger: "timer,0" #immeidate creation of this bearer immediately. Create after 10 sec time. |
| - repo: https://codeberg.org/fsfe/reuse-tool | ||
| rev: v6.2.0 | ||
| hooks: | ||
| - id: reuse |
cmaciocco
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.